KnockControllerBase Class Reference

#include <knock_logic.h>

Inheritance diagram for KnockControllerBase:

Collaboration diagram for KnockControllerBase:

Public Member Functions
	KnockControllerBase ()
void	onFastCallback () override
void	onKnockSenseCompleted (uint8_t cylinderNumber, float dbv, efitick_t lastKnockTime)
float	getFuelTrimMultiplier () const
float	getKnockRetard () const
uint32_t	getKnockCount () const
virtual float	getKnockThreshold () const =0
virtual float	getMaximumRetard () const =0
Public Member Functions inherited from EngineModule
virtual void	initNoConfiguration ()
virtual void	setDefaultConfiguration ()
virtual void	onConfigurationChange (engine_configuration_s const *)
virtual void	onSlowCallback ()
virtual void	onEngineStop ()
virtual void	onIgnitionStateChanged (bool)
virtual bool	needsDelayedShutoff ()
virtual void	onEnginePhase (float, efitick_t, angle_t, angle_t)

Private Types
using	PD = PeakDetect< float, MS2NT(50)>

Private Attributes
PD	peakDetectors [MAX_CYLINDER_COUNT]
PD	allCylinderPeakDetector

Additional Inherited Members
Data Fields inherited from knock_controller_s
float	m_knockLevel = (float)0
int8_t	m_knockCyl [MAX_CYLINDER_COUNT] = {}
angle_t	m_knockRetard = (angle_t)0
float	m_knockThreshold = (float)0
uint32_t	m_knockCount = (uint32_t)0
float	m_maximumRetard = (float)0
uint32_t	m_knockSpectrum [16] = {}
uint16_t	m_knockSpectrumChannelCyl = (uint16_t)0
uint16_t	m_knockFrequencyStart = (uint16_t)0
float	m_knockFrequencyStep = (float)0
float	m_knockFuelTrimMultiplier = (float)0

Detailed Description

Definition at line 17 of file knock_logic.h.

Member Typedef Documentation

PD

using KnockControllerBase::PD = PeakDetect<float, MS2NT(50)>

private

Definition at line 37 of file knock_logic.h.

Constructor & Destructor Documentation

KnockControllerBase()

KnockControllerBase::KnockControllerBase ( )

inline

Definition at line 19 of file knock_logic.h.

                          {
        // start with threshold higher than any possible knock to avoid recording spurious knocks
        m_knockThreshold = 100;
    }

Member Function Documentation

getFuelTrimMultiplier()

float KnockControllerBase::getFuelTrimMultiplier

(

)

const

Definition at line 94 of file knock_controller.cpp.

                                                       {
    return 1.0 + m_knockFuelTrimMultiplier;
}

getKnockCount()

uint32_t KnockControllerBase::getKnockCount

(

)

const

Definition at line 90 of file knock_controller.cpp.

                                                  {
    return m_knockCount;
}

getKnockRetard()

float KnockControllerBase::getKnockRetard

(

)

const

Definition at line 86 of file knock_controller.cpp.

                                                {
    return m_knockRetard;
}

getKnockThreshold()

virtual float KnockControllerBase::getKnockThreshold ( ) const

pure virtual

Implemented in KnockController.

Referenced by onFastCallback().

Here is the caller graph for this function:

getMaximumRetard()

virtual float KnockControllerBase::getMaximumRetard ( ) const

pure virtual

Implemented in KnockController.

Referenced by onFastCallback().

Here is the caller graph for this function:

onFastCallback()

void KnockControllerBase::onFastCallback ( )

overridevirtual

Reimplemented from EngineModule.

Definition at line 98 of file knock_controller.cpp.

                                         {
    m_knockThreshold = getKnockThreshold();
    m_maximumRetard = getMaximumRetard();
 
    constexpr auto callbackPeriodSeconds = FAST_CALLBACK_PERIOD_MS / 1000.0f;
 
    auto applyRetardAmount = engineConfiguration->knockRetardReapplyRate * callbackPeriodSeconds;
    auto applyFuelAmount = engineConfiguration->knockFuelTrimReapplyRate * 0.01f * callbackPeriodSeconds;
 
    // disable knock suppression then deceleration
    auto TPSValue = Sensor::getOrZero(SensorType::Tps1);
 
    {
        // Adjust knock retard under lock
        chibios_rt::CriticalSectionLocker csl;
 
 
         if(TPSValue < engineConfiguration->knockSuppressMinTps) {
            m_knockRetard = 0.0;
            m_knockFuelTrimMultiplier = 0.0;
            return;
         }
 
        // Reduce knock retard at the requested rate
        float newRetard = m_knockRetard - applyRetardAmount;
 
        // don't allow retard to go negative
        if (newRetard < 0) {
            m_knockRetard = 0;
        } else {
            m_knockRetard = newRetard;
        }
 
        // Reduce fuel trim at the requested rate
        float newTrim = m_knockFuelTrimMultiplier - applyFuelAmount;
 
        // don't allow trim to go negative
        if (newTrim < 0) {
            m_knockFuelTrimMultiplier = 0;
        } else {
            m_knockFuelTrimMultiplier = newTrim;
        }
    }
}

Here is the call graph for this function:

onKnockSenseCompleted()

void KnockControllerBase::onKnockSenseCompleted	(	uint8_t	cylinderNumber,
		float	dbv,
		efitick_t	lastKnockTime
	)

Definition at line 43 of file knock_controller.cpp.

                                                                                                          {
    bool isKnock = dbv > m_knockThreshold;
 
    // Per-cylinder peak detector
    float cylPeak = peakDetectors[cylinderNumber].detect(dbv, lastKnockTime);
    m_knockCyl[cylinderNumber] = roundf(cylPeak);
 
    // All-cylinders peak detector
    m_knockLevel = allCylinderPeakDetector.detect(dbv, lastKnockTime);
 
    if (isKnock) {
        m_knockCount++;
 
        auto baseTiming = engine->engineState.timingAdvance[cylinderNumber];
 
        // TODO: 20 configurable? Better explanation why 20?
        auto distToMinimum = baseTiming - (-20);
 
        // percent -> ratio = divide by 100
        auto retardFraction = engineConfiguration->knockRetardAggression * 0.01f;
        auto retardAmount = distToMinimum * retardFraction;
 
    // TODO: remove magic 30% m_maximumFuelTrim?
    auto maximumFuelTrim = 0.3f;
 
        auto  trimFuelFraction = engineConfiguration->knockFuelTrimAggression * 0.01f;
        float trimFuelPercent = clampF(0.f, (float)engineConfiguration->knockFuelTrim, maximumFuelTrim * 100.f);
        float trimFuelAmountPercent = trimFuelPercent * trimFuelFraction;
        float trimFuelAmount = trimFuelAmountPercent / 100.f;
 
        {
            // Adjust knock retard under lock
            chibios_rt::CriticalSectionLocker csl;
 
            auto newRetard = m_knockRetard + retardAmount;
            m_knockRetard = clampF(0.f, newRetard, m_maximumRetard);
 
            auto newFuelTrim = m_knockFuelTrimMultiplier + trimFuelAmount;
            m_knockFuelTrimMultiplier = clampF(0.f, newFuelTrim, maximumFuelTrim);
        }
    }
}

Here is the call graph for this function:

Field Documentation

allCylinderPeakDetector

PD KnockControllerBase::allCylinderPeakDetector

private

Definition at line 39 of file knock_logic.h.

Referenced by onKnockSenseCompleted().

peakDetectors

PD KnockControllerBase::peakDetectors[MAX_CYLINDER_COUNT]

private

Definition at line 38 of file knock_logic.h.

Referenced by onKnockSenseCompleted().

---

The documentation for this class was generated from the following files:

• controllers/engine_cycle/knock_logic.h
• controllers/engine_cycle/knock_controller.cpp