Support for Subaru EZ30 trigger
- Dron_Gus
- contributor
- Posts: 460
- Joined: Wed Nov 13, 2013 1:11 pm
- Location: S-Pb
- Github Username: dron0gus
Support for Subaru EZ30 trigger
Does this one looks the same as some of 36/x/y triggers that RE already supports?
- Attachments
-
- IMG-20220616-WA0031.jpg (70.14 KiB) Viewed 16596 times
-
- 20220617_191946.jpg (63.39 KiB) Viewed 16596 times
-
- running engine in first post
- Posts: 1495
- Joined: Mon Jan 30, 2017 2:05 am
- Location: Seattle-ish
Re: Support for Subaru EZ30 trigger
Maybe the same as RX8 36/2/2/2?
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
Oh also https://github.com/rusefi/rusefi/issues/4256 but that's probably not a problem here
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
- NormanAlphaspeed
- Posts: 66
- Joined: Fri Jan 13, 2017 7:15 am
- Location: Puerto Rico
- Contact:
Re: Support for Subaru EZ30 trigger
Later Subaru does use the same trigger as RX8, just in care, 36-2-2-2
AlphaX Auto Electronics
https://www.facebook.com/AlphaXAutoElectronics/
Tuned by AlphaSpeed
https://www.facebook.com/AlphaSpeedPR
https://www.facebook.com/AlphaXAutoElectronics/
Tuned by AlphaSpeed
https://www.facebook.com/AlphaSpeedPR
- Dron_Gus
- contributor
- Posts: 460
- Joined: Wed Nov 13, 2013 1:11 pm
- Location: S-Pb
- Github Username: dron0gus
Re: Support for Subaru EZ30 trigger
Thanks everyone!
Customer is still gathering debug data.
I'll get back with update as soon as receive something. Or visit him.
Customer is still gathering debug data.
I'll get back with update as soon as receive something. Or visit him.
Re: Support for Subaru EZ30 trigger
Hello everyone, this is my problem Andrey created this topic. So far managed to get data from the RE developer console. There is no synchronization, but I tried to reverse the polarity of the VR crankshaft sensor in software and hardware. In non-reversed polarity,
I counted 18 teeth, then 2 missing teeth, then 9 teeth, then 2 missing teeth, and 2 more missing teeth. If inverted, I get 19 teeth -2, then 10 -2 -2 Right now I don't have the paid version of TS. If this helps a lot in solving the problem, then soon I will buy it.
In the part of the code https://github.com/rusefi/rusefi/blob/master/firmware/controllers/trigger/decoders/trigger_subaru.cpp#L57 of the for loop, the teeth are counted up to 12 and skipped, then 15 teeth and two more skipped sectors 2 teeth. Do I understand correctly that in this case I should look like this
for (int i = 0; i < 18; i++) {
s->addEvent720(base + narrow / 2, T_PRIMARY, TV_FALL);
s->addEvent720(base + narrow, T_PRIMARY, TV_RISE);
base += narrow;
}
s->addEvent720(base + wide / 2, T_PRIMARY, TV_FALL);
s->addEvent720(base + wide, T_PRIMARY, TV_RISE);
base += wide;
for (int i = 0; i < 9; i++) {
s->addEvent720(base + narrow / 2, T_PRIMARY, TV_FALL);
s->addEvent720(base + narrow, T_PRIMARY, TV_RISE);
base += narrow;
}
s->addEvent720(720 - wide - wide / 2, T_PRIMARY, TV_FALL);
s->addEvent720(720 - wide, T_PRIMARY, TV_RISE);
s->addEvent720(720 - wide / 2, T_PRIMARY, TV_FALL);
s->addEvent720(720, T_PRIMARY, TV_RISE);
s->useOnlyPrimaryForSync = true;
After all, if the FOR loop counts up to 12, then the gap between 13 and 14 teeth will be considered as 2 missing teeth.
Sorry for my bad english, I use google translator
I counted 18 teeth, then 2 missing teeth, then 9 teeth, then 2 missing teeth, and 2 more missing teeth. If inverted, I get 19 teeth -2, then 10 -2 -2 Right now I don't have the paid version of TS. If this helps a lot in solving the problem, then soon I will buy it.
In the part of the code https://github.com/rusefi/rusefi/blob/master/firmware/controllers/trigger/decoders/trigger_subaru.cpp#L57 of the for loop, the teeth are counted up to 12 and skipped, then 15 teeth and two more skipped sectors 2 teeth. Do I understand correctly that in this case I should look like this
for (int i = 0; i < 18; i++) {
s->addEvent720(base + narrow / 2, T_PRIMARY, TV_FALL);
s->addEvent720(base + narrow, T_PRIMARY, TV_RISE);
base += narrow;
}
s->addEvent720(base + wide / 2, T_PRIMARY, TV_FALL);
s->addEvent720(base + wide, T_PRIMARY, TV_RISE);
base += wide;
for (int i = 0; i < 9; i++) {
s->addEvent720(base + narrow / 2, T_PRIMARY, TV_FALL);
s->addEvent720(base + narrow, T_PRIMARY, TV_RISE);
base += narrow;
}
s->addEvent720(720 - wide - wide / 2, T_PRIMARY, TV_FALL);
s->addEvent720(720 - wide, T_PRIMARY, TV_RISE);
s->addEvent720(720 - wide / 2, T_PRIMARY, TV_FALL);
s->addEvent720(720, T_PRIMARY, TV_RISE);
s->useOnlyPrimaryForSync = true;
After all, if the FOR loop counts up to 12, then the gap between 13 and 14 teeth will be considered as 2 missing teeth.
Sorry for my bad english, I use google translator
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
Let's slow down a bit
Why are we trying to code anything? Do we believe that your trigger is not 36-2-2-2? Do we have _any_ data about your trigger?
Is it Subaru which has nice workshop manual or is it just Nissan? Any photos from the internet? Etc? Overall, what are we trying to change why based on what data exactly?
Why are we trying to code anything? Do we believe that your trigger is not 36-2-2-2? Do we have _any_ data about your trigger?
Is it Subaru which has nice workshop manual or is it just Nissan? Any photos from the internet? Etc? Overall, what are we trying to change why based on what data exactly?
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Re: Support for Subaru EZ30 trigger
Excuse me for my rush, the upcoming business trip will slow me down by a week. That's right, my trigger is 36-2-2-2 and so far I don't have the logs from TunerStudio Tooth Logger.AndreyB wrote: ↑Mon Jun 20, 2022 12:03 amLet's slow down a bit
Why are we trying to code anything? Do we believe that your trigger is not 36-2-2-2? Do we have _any_ data about your trigger?
Is it Subaru which has nice workshop manual or is it just Nissan? Any photos from the internet? Etc? Overall, what are we trying to change why based on what data exactly?
My logic proceeds from the fact that in the code there is a calculation of the sequence of 12 consecutive teeth and two missing ones, then there is a count of 15 teeth and 2 more sectors of -2 teeth.
Whereas I have 10 teeth -2 and another 19 -2 -2. Here is an image of the RX8 13b engine trigger, here 16 |-2| 13| -2 |-2.
Let me know where I'm wrong, I don't understand at all how the 13th tooth between the -2 and -2 sectors is considered. I have a very poor understanding of the logic of the code since I am very weak in programming
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
- Dron_Gus
- contributor
- Posts: 460
- Joined: Wed Nov 13, 2013 1:11 pm
- Location: S-Pb
- Github Username: dron0gus
Re: Support for Subaru EZ30 trigger
Console sniffer
- Attachments
-
- 2022-07-10_15_19_15_204rpm_0_maf_0.0.png (32.91 KiB) Viewed 16184 times
- Dron_Gus
- contributor
- Posts: 460
- Joined: Wed Nov 13, 2013 1:11 pm
- Location: S-Pb
- Github Username: dron0gus
Re: Support for Subaru EZ30 trigger
And fast logger from TS.
- Attachments
-
- 2022-07-10_15.20.10.csv
- (19.48 KiB) Downloaded 216 times
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
Happy or unhappy?
verbose trigger loggier text output?
verbose trigger loggier text output?
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
sync has nothing to do with overall shape
if it sync it would kind of work with very wrong shape
enable "log trigger details" in TS
switch to console, crank
copy-paste text from messages which would looks somewhat like
well, actually "normal" TS logs also have some useful info. Please ensure your logging data rate is high and upload normal log (not tooth log) to rusefi online
I shall document more of that at https://github.com/rusefi/rusefi/wiki/Trigger-Configuration-Guide
if it sync it would kind of work with very wrong shape
enable "log trigger details" in TS
switch to console, crank
copy-paste text from messages which would looks somewhat like
Code: Select all
2021-11-06_16_49_03_605: EngineState: TRG rpm=268 time=822 eventIndex=114 gapIndex=0: gap=2.517 expected from 2.250 to 3.750 error=No
2021-11-06_16_49_03_605: EngineState: TRG rpm=268 time=822 eventIndex=114 gapIndex=1: gap=1.000 expected from 0.750 to 1.250 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=0 gapIndex=0: gap=0.587 expected from 2.250 to 3.750 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=0 gapIndex=1: gap=2.517 expected from 0.750 to 1.250 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=2 gapIndex=0: gap=0.674 expected from 2.250 to 3.750 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=2 gapIndex=1: gap=0.587 expected from 0.750 to 1.250 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=4 gapIndex=0: gap=0.995 expected from 2.250 to 3.750 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=4 gapIndex=1: gap=0.674 expected from 0.750 to 1.250 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=6 gapIndex=0: gap=1.007 expected from 2.250 to 3.750 error=No
2021-11-06_16_49_03_620: EngineState: TRG rpm=268 time=822 eventIndex=6 gapIndex=1: gap=0.995 expected from 0.750 to 1.250 error=No
well, actually "normal" TS logs also have some useful info. Please ensure your logging data rate is high and upload normal log (not tooth log) to rusefi online
I shall document more of that at https://github.com/rusefi/rusefi/wiki/Trigger-Configuration-Guide
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
-
- running engine in first post
- Posts: 1495
- Joined: Mon Jan 30, 2017 2:05 am
- Location: Seattle-ish
Re: Support for Subaru EZ30 trigger
swap your VR sensor wires edit: nope, it looks fine
Try setting your trigger gap overrides like this:
Try setting your trigger gap overrides like this:
Re: Support for Subaru EZ30 trigger
Thank you very much, the redistribution of intervals helped me !!! Synchronization is now clear and without disruptions.
Today even almost started the engine, greatly frightened the entire covered parking lot with a strong explosion =)) Now I need to adjust the cam sensor and pull #1 TDC. Hopefully there won't be a problem with that. Many thanks to Andrew and all those who responded!! I am very happy
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
@mck1117 how did you come up with the numbers you've suggested for gaps?
@WOOL your tune and log on http://rusefi.online would be the nice next step
@WOOL your tune and log on http://rusefi.online would be the nice next step
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Re: Support for Subaru EZ30 trigger
Exactly! Already doneAndreyB wrote: ↑Thu Jul 14, 2022 8:54 pm@mck1117 how did you come up with the numbers you've suggested for gaps?
@WOOL your tune and log on http://rusefi.online would be the nice next step
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
In the future please explicitily link relevant tunes and logs. Time will pass and it would be unclear what tunes and logs are relevant for this specific forum thread.
I see https://rusefi.com/online/view.php?msq=1118 but I see no logs of vehicle running please add a log of vehicle running that's the more important part to see actual trigger gap behaviour.
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
Follow-up work https://github.com/rusefi/rusefi/issues/4344
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
-
- running engine in first post
- Posts: 1495
- Joined: Mon Jan 30, 2017 2:05 am
- Location: Seattle-ish
Re: Support for Subaru EZ30 trigger
The "perfect" gaps are only any good when the engine is spinning smoothly - basically once it's running. On engines that have the gap in a "bad" spot, plus have lots of cranking speed variation (high compression, few cylinders, weak starter, weak battery, etc), the gaps end up pretty messy during cranking.
With this wheel, the "ideal" pattern is gap ratios of 3, 1, 0.33: first the short-long, long-long, then long-short.
But in reality, from the TS log, we see:
Ideally those 4 gaps have width of x, 3x, 3x, x, but you can see that's just not the case.
Checking against the default +-25% ranges for the 3, 1, 0.33 gaps, the middle one is out: 1.31 is too high.
The numbers I suggested cover both the ratios we see during cranking, and the expected ratios during running, plus some margin.
First gap: expected 0.33 cranking 0.35, range given 0.25-0.5
Second gap: expected 1 cranking 1.31, range given 0.7-1.5
Third gap: expected 3 cranking 3.26, range given 2-4
It's fine to make the gaps wider, so long as it doesn't introduce any ambiguity in the trigger. Whatever the gaps are, there must be exactly one spot in the trigger pattern that yields a sync, regardless of engine acceleration.
This is actually the less interesting part, as it's easy to predict. The gaps we see during cranking are much harder to predict.
Re: Support for Subaru EZ30 trigger
So, I started the engine. TDC #1 Angles are correct, Trigger is defined correctly. But with the CAM sensor is not yet clear. The cam trigger seems to be visible in the console, but sometimes shifts. I suspect that there are some noises from which there are false positives, Attach Logs and tune
The first screenshot shows that the CAM is positioned correctly. And at this point, the third pattern is shifted forward.
The first screenshot shows that the CAM is positioned correctly. And at this point, the third pattern is shifted forward.
- Attachments
-
- 2022-09-06_17.55.31.msl
- (6.03 MiB) Downloaded 190 times
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
2022-09-06_17.55.31.msl looks like a corrupted text log file, what software have you used how to get it?
The most reliable logs are the ones created by TunerStudio and uploaded to rusefi.online
The most reliable logs are the ones created by TunerStudio and uploaded to rusefi.online
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Re: Support for Subaru EZ30 trigger
I think you need to override the TDC #1 position for the EZ30 triggerer. I now have a 240 degree offset for the TDC to match Cylinder #1. Also I use Trigger gap override What advised me mck1117. At home on the stand with an even rotation, the determination of the trigger will occur without trigger gap override, but on the engine only with these intervals.
Tune https://rusefi.com/online/view.php?msq=1418
Log https://rusefi.com/online/view.php?log=1194
I also attach a tune and a logTune https://rusefi.com/online/view.php?msq=1418
Log https://rusefi.com/online/view.php?log=1194
- AndreyB
- Site Admin
- Posts: 14360
- Joined: Wed Aug 28, 2013 1:28 am
- Location: Jersey City
- Github Username: rusefillc
- Slack: Andrey B
Re: Support for Subaru EZ30 trigger
Gaps were improved a while ago https://github.com/rusefi/rusefi/commit/122db2de9505b38b3e5d671ef72724c83ccde716
Just improved the tdcPosition https://github.com/rusefi/rusefi/commit/033c2e2bb945b91e632a349d72e4029308bf2f68
Just improved the tdcPosition https://github.com/rusefi/rusefi/commit/033c2e2bb945b91e632a349d72e4029308bf2f68
Very limited telepathic abilities - please post logs & tunes where appropriate - http://rusefi.com/s/questions
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Always looking for C/C++/Java/PHP developers! Please help us see https://rusefi.com/s/howtocontribute
Re: Support for Subaru EZ30 trigger
I just found a description of the simulation of the first and second generation EZ30 sensors from the well-known github page of the Crank\Cam signal simulator. But unfortunately, I don't understand much about this.? =)
https://github.com/speeduino/Ardu-Stim/pull/60
https://github.com/speeduino/Ardu-Stim/pull/60