36-4 trigger wheel
Posted: Sun Dec 27, 2015 7:13 pm
by PhilTheGeek
I'm trying to implement support for a Rover K series 36-4 trigger pattern. This is 13-1-2-1-14-1-3-1 where the 1's are missing teeth. There's no camshaft sensor so this needs to sync on the crank alone. Code as it stands is below. It works without the two commented lines but isn't sync'd so TDC can be anywhere. If I uncomment then I get the orange LED flashing and "line:52:msg,FATAL error: totalRevolutionCounter2 expected 3" repeated in the console. Am I going to be able to sort this without adding a camshaft sensor?
Code: Select all
void configureKMpiTriggerShape(TriggerShape *s DECLARE_ENGINE_PARAMETER_S)
{
s->initialize(FOUR_STROKE_CRANK_SENSOR, false);
float tooth = 20;
// s->setTriggerSynchronizationGap(2.0);
// s->isSynchronizationNeeded = true;
float base = 0;
for (int i = 0; i < 2; i++)
{
s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
base += tooth;
}
base += tooth;
for (int i = 0; i < 2; i++) {
s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
base += tooth;
}
base += tooth;
for (int i = 0; i < 14; i++) {
s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
base += tooth;
}
base += tooth;
for (int i = 0; i < 3; i++) {
s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
base += tooth;
}
base += tooth;
for (int i = 0; i < 11; i++) {
s->addEvent(base + tooth / 2, T_PRIMARY, TV_RISE);
s->addEvent(base + tooth, T_PRIMARY, TV_FALL);
base += tooth;
}
}
Re: 36-4 trigger wheel
Posted: Sun Dec 27, 2015 7:53 pm
by AndreyB
PhilTheGeek wrote:"line:52:msg,FATAL error: totalRevolutionCounter2 expected 3"
I will now change this message to be more helpful: what is happening here is your 'gap' ratio is not 2 so synchronization validation fails.
I usually run unit_tests.exe with additional logging to see what are the actual gaps, you can try setting
Code: Select all
engineConfiguration->isPrintTriggerSynchDetails = true;
or add a breakpoint where it does gap calculation in trigger_decoder.
I will now figure this out for you, adding trigger_rover.cpp file as we speak.
Re: 36-4 trigger wheel
Posted: Sun Dec 27, 2015 8:10 pm
by AndreyB
Ops, my current algorithm is not capable of synchronizing such a trigger wheel
Since you are saying there is no cam sensor it sounds like I would need to improve my trigger decode.
Re: 36-4 trigger wheel
Posted: Mon Dec 28, 2015 10:27 pm
by PhilTheGeek
Excellent, that seems to work well on the bare discovery board.
Can I suggest a couple more files are modified?
TunerStudio ini file:
Line 135:
Change from:
trigger_type = bits, U32, 536, [0:4], "custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"
to:
trigger_type = bits, U32, 536, [0:4], "custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "Nissan", "2JZ", "Rover K", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"
Console fields.java:
Line 79:
Change from:
public static final String[] trigger_type_e = {"custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"};
To:
public static final String[] trigger_type_e = {"custom toothed wheel", "ford aspire", "dodge neon", "Miata NA", "Miata NB", "GM_7X", "Cooper", "Mazda SOHC 4", "60/2", "36/1", "Accord CD", "MITSU", "ACCORD 2", "ACCORD DIP", "Neon 2003", "MAZDA D 1+4", "1+1", "1+60/2", "Single Tooth", "Dodge Ram 1+16", "60/2 VW", "Accord 1+24", "DODGE STRATUS", "36_2_2_2", "Nissan", "2JZ", "Rover K", "INVALID", "INVALID", "INVALID", "INVALID", "INVALID"};
And lastly, I've read the contributor agreement and it's fine by me. Do you want a signed copy?
Re: 36-4 trigger wheel
Posted: Tue Dec 29, 2015 8:42 am
by KLAS
seems i lost all good reasons why i didn't made any progress with my Rover K engine ....
