Page 1 of 1

Feature request: engineConfig field for secondary fan.

Posted: Sat Dec 06, 2014 1:23 am
by spags
Hi,

My car as many other has two radiator fans, controlled separately. One for the cooling system and the other one for the a/c system.
Could we add a second fan relay pin field to the engine config struct?

Re: Feature request: engineConfig field for secondary fan.

Posted: Sat Dec 06, 2014 2:03 am
by AndreyB
spags wrote:Could we add a second fan relay pin field to the engine config struct?
I would say that's exactly the use-case for FSIO?

You might want something like

Code: Select all

	boardConfiguration->fsioPins[0] = GPIOD_11;
	strcpy(boardConfiguration->le_formulas[0], "coolant 80 >");
This case rusEfi does not have to know about second fan relay, and you can customize the logic of that as if it was FSIO output #1? See http://rusefi.com/wiki/index.php?title=Manual:Flexible_Logic see http://rusefi.com/forum/viewtopic.php?f=5&t=612

Re: Feature request: engineConfig field for secondary fan.

Posted: Sat Dec 06, 2014 2:16 am
by AndreyB
PS: fsioPins are already available via TunerStudio
there would be 'fsio_setting' - user-accessible settings - available on TS pretty soon

Re: Feature request: engineConfig field for secondary fan.

Posted: Sat Dec 06, 2014 5:33 pm
by spags
New fsio feature seems to cause a HardFault.

Steps to reproduce:
Flash with 5698.
Reboot board.
set_engine_type 24
Hardfault


If i remove:
setFsio(engineConfiguration, 0, GPIOD_11, "coolant 80 >");
from my config, everything works fine.

Re: Feature request: engineConfig field for secondary fan.

Posted: Sat Dec 06, 2014 8:11 pm
by AndreyB
spags wrote:New fsio feature seems to cause a HardFault.
Yep, there were issues :(

5708 should be better.

Re: Feature request: engineConfig field for secondary fan.

Posted: Sat Dec 06, 2014 8:23 pm
by spags
Ok, not crashing the board this time. Will do functional tests later today.

Re: Feature request: engineConfig field for secondary fan.

Posted: Sat Dec 06, 2014 8:24 pm
by AndreyB
spags wrote:Ok, not crashing the board this time. Will do functional tests later today.
fsioinfo should be showing the state of configuration in not-yet-very-readable form